fix: add missing await for isDynamicFramework check #4955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a missing await in the check if an iOS Framework is dynamic. Linter rule (no-floating-promises) does not catch it, as it is not a pure call, i.e. linter will fail in case the code is: ``` this.isDynamicFramework(frameworkPath); ``` But it will not fail in case the method is called inside if statement (as it is in our code) or when you assing the value to a variable and do not await it anywhere: ``` const isDynamic = this.isDynamicFramework(frameworkPath); ```
|
test cli-smoke |
1 similar comment
|
test cli-smoke |
mbektchiev
approved these changes
Aug 19, 2019
The current check if `.framework` files are dynamically linked frameworks is not working as we pass only the framework name. This breaks all projects as tns-core-modules-widgets have `.framework`, CLI decides it is not dynamically linked and the application cannot run on device. Fix the check to pass the full path to the framework.
|
test cli-smoke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a missing await in the check if an iOS Framework is dynamic. Linter rule (no-floating-promises) does not catch it, as it is not a pure call, i.e. linter will fail in case the code is:
But it will not fail in case the method is called inside if statement (as it is in our code) or when you assing the value to a variable and do not await it anywhere:
PR Checklist
What is the current behavior?
What is the new behavior?
Related to: #4906